-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8s: Allow connectors to be deployed with operator. #9
Conversation
type RedpandaConnectors struct { | ||
Enabled *bool `json:"enabled,omitempty"` | ||
|
||
Deployment *ConnectorsCreateObj `json:"deployment,omitempty"` | ||
Test *ConnectorsCreateObj `json:"test,omitempty"` | ||
} | ||
|
||
type ConnectorsCreateObj struct { | ||
Create *bool `json:"enabled,omitempty"` | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be only part of the configuration. It only reflects Redpanda values where user could define Connectors values in standard helm deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Consider this the first part. For now I want to unblock users so they can deploy connectors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I don't like how we are omiting Connectors possible values.
ac1da7b
to
37c4ed9
Compare
Not all tests are running. I want to merge this in first since it resolves a few issues with tests and local tests for kuttl pass. Nothing major was done here. Next step is to get tests to run to regain confidence in our code after the migration to this repo. |
Fixes redpanda-data/helm-charts#877