K8s: Allow connectors to be deployed with operator. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+169
to
+178
| type RedpandaConnectors struct { | ||
| Enabled *bool `json:"enabled,omitempty"` | ||
|
|
||
| Deployment *ConnectorsCreateObj `json:"deployment,omitempty"` | ||
| Test *ConnectorsCreateObj `json:"test,omitempty"` | ||
| } | ||
|
|
||
| type ConnectorsCreateObj struct { | ||
| Create *bool `json:"enabled,omitempty"` | ||
| } |
There was a problem hiding this comment.
This should be only part of the configuration. It only reflects Redpanda values where user could define Connectors values in standard helm deployment.
There was a problem hiding this comment.
Yes. Consider this the first part. For now I want to unblock users so they can deploy connectors.
RafalKorepta
approved these changes
Nov 16, 2023
alejandroEsc
force-pushed
the
ae/connectors
branch
from
ac1da7b
to
37c4ed9
Compare
|
Not all tests are running. I want to merge this in first since it resolves a few issues with tests and local tests for kuttl pass. Nothing major was done here. Next step is to get tests to run to regain confidence in our code after the migration to this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes redpanda-data/helm-charts#877