Skip to content

Commit

Permalink
k/group: do not log ignoring raft configuration batches
Browse files Browse the repository at this point in the history
Raft configuration batches are integral part of Raft managed log.
Emitting warn log message that Redpanda ignore them when parsing
consumer group state machine data may be confusing as this is expected
and not something that the users should worry about.

Signed-off-by: Michał Maślanka <michal@redpanda.com>
  • Loading branch information
mmaslankaprv committed Jul 15, 2024
1 parent a4e54a3 commit 0d7a1d5
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/v/kafka/server/group_data_parser.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#include "kafka/server/group_metadata.h"
#include "kafka/server/logger.h"
#include "model/record.h"
#include "model/record_batch_types.h"

template<typename T>
T parse_tx_batch(const model::record_batch& batch, int8_t version) {
Expand Down Expand Up @@ -81,6 +82,10 @@ class group_data_parser {
if (b.header().type == model::record_batch_type::raft_data) {
return handle_raft_data(std::move(b));
}
// silently ignore raft configuration.
if (b.header().type == model::record_batch_type::raft_configuration) {
return ss::now();
}
if (b.header().type == model::record_batch_type::group_prepare_tx) {
auto data = parse_tx_batch<kafka::group_tx::offsets_metadata>(
b, group::prepared_tx_record_version);
Expand Down

0 comments on commit 0d7a1d5

Please sign in to comment.