Merge pull request #18723 from r-vasquez/patch-no-arg-plugin

rpk: explicitly add Arg validation to plugins
redpanda-data · May 30, 2024 · 2b3ee2e · 2b3ee2e
2 parents 849f50a + 0c9a20b
commit 2b3ee2e
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/go/rpk/pkg/cli/plugin_cmds.go b/src/go/rpk/pkg/cli/plugin_cmds.go
@@ -88,6 +88,7 @@ func addPluginWithExec(
 			Use:                p0,
 			Short:              p0 + pluginShortSuffix,
 			DisableFlagParsing: true,
+			Args:               cobra.MinimumNArgs(0),
 			Run: func(cmd *cobra.Command, args []string) {
 				keepForPlugin, _ := cobraext.StripFlagset(args, cmd.InheritedFlags()) // strip all rpk specific flags before execing the plugin
 				err := osExec(execPath, keepForPlugin)
@@ -263,6 +264,7 @@ func addPluginSubcommands(
 		childCmd := &cobra.Command{
 			Short:              fmt.Sprintf("%s external plugin", childUse),
 			DisableFlagParsing: true,
+			Args:               cobra.MinimumNArgs(0),
 			Run: func(cmd *cobra.Command, args []string) {
 				keepForPlugin, _ := cobraext.StripFlagset(args, cmd.InheritedFlags()) // strip all rpk specific flags before execing the plugin
 				osExec(execPath, append(append(leadingPieces, cmd.Use), keepForPlugin...))