Merge pull request #8878 from rystsov/issue-8877

cluster: send metadata updates to all nodes
redpanda-data · Feb 15, 2023 · e314110 · e314110
2 parents 30fe679 + 7a3caec
commit e314110
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 163 deletions.
diff --git a/src/v/cluster/CMakeLists.txt b/src/v/cluster/CMakeLists.txt
@@ -88,7 +88,6 @@ v_cc_library(
     service.cc
     metadata_dissemination_handler.cc
     metadata_dissemination_service.cc
-    metadata_dissemination_utils.cc
     types.cc
     notification_latch.cc
     topic_table.cc

diff --git a/src/v/cluster/metadata_dissemination_service.cc b/src/v/cluster/metadata_dissemination_service.cc
@@ -17,7 +17,6 @@
 #include "cluster/metadata_cache.h"
 #include "cluster/metadata_dissemination_rpc_service.h"
 #include "cluster/metadata_dissemination_types.h"
-#include "cluster/metadata_dissemination_utils.h"
 #include "cluster/partition_leaders_table.h"
 #include "cluster/partition_manager.h"
 #include "cluster/topic_table.h"
@@ -290,19 +289,11 @@ void metadata_dissemination_service::collect_pending_updates() {
             // Partition was removed, skip dissemination
             continue;
         }
-        auto non_overlapping = calculate_non_overlapping_nodes(
-          *assignment, brokers);
-
-        /**
-         * remove current node from non overlapping list, current node may be
-         * included into non overlapping node when new metadata set is used to
-         * calculate non overlapping nodes but partition replica still exists on
-         * current node (it is being moved)
-         */
-        std::erase_if(non_overlapping, [this](model::node_id n) {
-            return n == _self.id();
-        });
-        for (auto& id : non_overlapping) {
+
+        for (auto& id : brokers) {
+            if (id == _self.id()) {
+                continue;
+            }
             if (!_pending_updates.contains(id)) {
                 _pending_updates.emplace(
                   id, update_retry_meta{std::vector<ntp_leader_revision>{}});

diff --git a/src/v/cluster/metadata_dissemination_utils.cc b/src/v/cluster/metadata_dissemination_utils.cc
diff --git a/src/v/cluster/metadata_dissemination_utils.h b/src/v/cluster/metadata_dissemination_utils.h
diff --git a/src/v/cluster/tests/CMakeLists.txt b/src/v/cluster/tests/CMakeLists.txt
@@ -6,15 +6,6 @@ rp_test(
   LABELS cluster
 )
 
-rp_test(
-  UNIT_TEST
-  BINARY_NAME metadata_dissemination_utils_test
-  SOURCES metadata_dissemination_utils_test.cc
-  DEFINITIONS BOOST_TEST_DYN_LINK
-  LIBRARIES Boost::unit_test_framework v::cluster
-  LABELS cluster
-)
-
 set(srcs
     partition_allocator_tests.cc
     partition_balancer_planner_test.cc

diff --git a/src/v/cluster/tests/metadata_dissemination_utils_test.cc b/src/v/cluster/tests/metadata_dissemination_utils_test.cc