-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Failure (bad_deltas anomaly) in RedpandaUpgradeTest.test_workloads_through_releases
#11842
Comments
This could either be a bug in a historic redpanda or a bug in the tool's handling of legacy manifests which miss some deltas. Until we know otherwise, let's assume it's a real issue. |
from test_log.debug:
this i produced by this class
Which generates a simple message on each cluster version:
so 13 messages in total. |
running the check after every upgrade step, shows that ntpr_bad_deltas is generated after installing and checking HEAD. this is 40000000_meta_kafka_topic-MinimalWorkload-fcb57d39-5b31-4c2a-84d6-a063912da293_0_15_manifest.json
|
@andijcr what is next here? |
This is showing up as failing a lot. |
finally got some more output out of rp-storage-tool
unfortunately, cloud_diagnostic.zip does not contains the file, but nothing that can't be fixed in ducktape |
It's caused by rp-storage-tool not accounting for old segment_meta with a defaulted delta_offset_end. In redpanda, this is already handled in partition_manifest by checking the value of delta_offset_end != model::offset to decide if it's valid or not. in the decoded manifest, delta_offset_end that have the value 9223372036854775808 should be ignored. (it should be a negative number, std::numeric_limits<int64_t>::min(), not sure if the error is in the datatype used or in the json handling of int64_t)
manifest v1, json
segment.base_offset=2 does not have a predecessor with delta_offset_end, so i could not trigger rp-storage-tool. manifest v2 in bin format (and decoded json representation)
|
@andijcr : Sorry not clear, so a tool defect and no real RP issue? |
tool defect |
https://buildkite.com/redpanda/redpanda/builds/32382#01891a7b-8348-4279-b724-633f25042597
The text was updated successfully, but these errors were encountered: