Made prevote phase not resetting last heartbeat timestamp #11726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaslankaprv
changed the title
Made entries indicating receiving append entries and vote request more obvious. Signed-off-by: Michal Maslanka <michal@redpanda.com>
Signed-off-by: Michal Maslanka <michal@redpanda.com>
When a voter receives vote request and it votes for the candidate it updates the last heartbeat timeout. If this happens during the prevote phase and in a deployment with even number of locks it may lead to temporary live lock and not being able to elect the leader. Fixes: redpanda-data#11657 Signed-off-by: Michal Maslanka <michal@redpanda.com>
Added test verifying if a controller is elected in timely fashion when some of the cluster nodes are down. Signed-off-by: Michal Maslanka <michal@redpanda.com>
bharathv
approved these changes
Jul 6, 2023
|
/ci-repeat 1 |
1 similar comment
|
/ci-repeat 1 |
|
Unrelaed failures: |
|
/ci-repeat 1 |
|
/backport v23.1.x |
|
/backport v22.3.x |
|
Failed to run cherry-pick command. I executed the commands below: |
|
Failed to run cherry-pick command. I executed the commands below: |
This was referenced Jul 11, 2023
7 tasks
mmaslankaprv
added a commit
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a voter receives vote request and it votes for the candidate it
updates the last heartbeat timeout. If this happens during the prevote
phase and in a deployment with even number of locks it may lead to
temporary live lock and not being able to elect the leader.
Fixes: #11657
Backports Required
Release Notes
Improvements