Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deleting subject compatibility in schema registry #13229

Closed
weeco opened this issue Sep 1, 2023 · 4 comments · Fixed by #13557
Closed

Add support for deleting subject compatibility in schema registry #13229

weeco opened this issue Sep 1, 2023 · 4 comments · Fixed by #13557
Assignees
Labels
area/schema-registry Schema Registry service within Redpanda kind/enhance New feature or request

Comments

@weeco
Copy link

weeco commented Sep 1, 2023

Who is this for and what problem do they have today?

Redpanda's schema registry allows to register a subject compatibility level using the PUT /config/{subject} endpoint, but you can never unset and default to the global default again anymore, because the respective DELETE endpoint does not exist.

What are the success criteria?

The DELETE /config/{subject} endpoint is implemented in an API compatible fashion. The confluent schema registry PR can be found here: confluentinc/schema-registry#1780

Why is solving this problem impactful?

Without this endpoint you can never unset what you have set before.

Additional notes

@weeco weeco added kind/enhance New feature or request area/schema-registry Schema Registry service within Redpanda labels Sep 1, 2023
@oleiman oleiman self-assigned this Sep 15, 2023
@oleiman
Copy link
Member

oleiman commented Oct 18, 2023

Question for @piyushredpanda and/or @weeco - are you (or anyone else) expecting/needing a backport of this feature?

@piyushredpanda
Copy link
Contributor

I don't see a downside to backporting it, but then again, who is going to use it in prior releases (if not Console)? I suggest we not backport unless @weeco is going to use it with v23.2.x releases.

@weeco
Copy link
Author

weeco commented Oct 19, 2023

Console would indeed use this feature in v23.2. If not too much effort a backport would be nice I believe. Why? We are about to roll out the Console changes with a much better schema registry management. One of these new features is to edit the schema compatibility, but users wouldn't be able to unset a set compatibility mode.

I can't judge how problematic that would be for some of our users.

@oleiman
Copy link
Member

oleiman commented Oct 23, 2023

If not too much effort a backport would be nice I believe

Looks like clean cherry-picks into 23.2.x and 23.1.x, so we should be all good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/schema-registry Schema Registry service within Redpanda kind/enhance New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants