Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DGS-1328 Add DELETE API for subject config and subject mode #1780

Merged
merged 4 commits into from
Feb 24, 2021

Conversation

xiaoyali97
Copy link
Member

@xiaoyali97 xiaoyali97 commented Feb 23, 2021

Done manual test, will update system tests later.

Example usage:

 % curl -X GET http://localhost:8081/config
{"compatibilityLevel":"BACKWARD"}%  
 % curl -X PUT -H "Content-Type: application/vnd.schemaregistry.v1+json" --data '{"compatibility": "FORWARD"}' http://localhost:8081/config/Kafka-key 
{"compatibility":"FORWARD"}%                                                                                                                                                                  
 % curl -X GET http://localhost:8081/config/Kafka-key                                                                                                
{"compatibilityLevel":"FORWARD"}%                                                                                                                                                              
 % curl -X DELETE -H "Content-Type: application/vnd.schemaregistry.v1+json" http://localhost:8081/config/Kafka-key
{"compatibilityLevel":"FORWARD"}%                                                                                                                                                              
 % curl -X GET http://localhost:8081/config/Kafka-key                                                             
{"error_code":40401,"message":"Subject 'Kafka-key' not found."}%                                                                                                                               
 % curl -X GET "http://localhost:8081/config/Kafka-key?defaultToGlobal=true"
{"compatibilityLevel":"BACKWARD"}%         

@xiaoyali97 xiaoyali97 changed the title add DELETE API for /config/{subject} DGS 1328 Add DELETE API for subject config and subject mode Feb 23, 2021
@xiaoyali97 xiaoyali97 changed the title DGS 1328 Add DELETE API for subject config and subject mode DGS-1328 Add DELETE API for subject config and subject mode Feb 23, 2021
@xiaoyali97 xiaoyali97 marked this pull request as ready for review February 23, 2021 23:54
@xiaoyali97 xiaoyali97 requested a review from a team February 24, 2021 00:02
Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xiaoyali97 , LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants