Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change subject-level mode DELETE response type from String to ModeGet… #1789

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

xiaoyali97
Copy link
Member

@xiaoyali97 xiaoyali97 commented Mar 4, 2021

…Response

What?
Change the subject-level Mode DELETE API reponse type, added in #1780

Test
Done manual test. The resource is also covered by existing unit tests.

 % curl -X PUT -H "Content-Type: application/vnd.schemaregistry.v1+json" \   
    --data '{"mode": "READONLY"}' \     
    http://localhost:8081/mode/Kafka-value
{"mode":"READONLY"}%                                                                                                                                                                           
 % curl -X DELETE -H "Content-Type: application/vnd.schemaregistry.v1+json" \
    http://localhost:8081/mode/Kafka-value
{"mode":"READONLY"}%   

@xiaoyali97 xiaoyali97 requested a review from a team March 4, 2021 19:55
@xiaoyali97 xiaoyali97 marked this pull request as draft March 4, 2021 20:07
@xiaoyali97 xiaoyali97 marked this pull request as ready for review March 4, 2021 20:08
Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoyali97 xiaoyali97 merged commit c9e3dee into confluentinc:master Mar 4, 2021
@xiaoyali97 xiaoyali97 deleted the string-to-mode branch March 4, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants