Using chunked_fifo in heartbeat_manager
#10915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `chunked_fifo` allows to reduce large allocations in heartbeat manager. Fixes: redpanda-data#10751 Signed-off-by: Michal Maslanka <michal@redpanda.com>
Signed-off-by: Michal Maslanka <michal@redpanda.com>
dotnwat
reviewed
May 23, 2023
Comment on lines
-276
to
+278
| absl::btree_map<raft::group_id, follower_request_meta> groups, | ||
| const absl::node_hash_map<raft::group_id, follower_request_meta>& groups, |
There was a problem hiding this comment.
i just wanted to accommodate to what we agreed previously in slack that the node_hash_map is better suited in the cases when we do not need ordering as it provides enough prevention from memory fragmentation.
|
ci failure: #10497 |
|
/backport v23.1.x |
This was referenced May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
ss::chunked_fifoin heartbeats manager when collecting node heartbeat requests.Fixes: #10751
Backports Required
Release Notes