-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: cloud failure injector #11234
Merged
andrewhsu
merged 11 commits into
redpanda-data:dev
from
andrewhsu:cloud-failure-injector
Jun 16, 2023
Merged
tests: cloud failure injector #11234
andrewhsu
merged 11 commits into
redpanda-data:dev
from
andrewhsu:cloud-failure-injector
Jun 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhsu
force-pushed
the
cloud-failure-injector
branch
2 times, most recently
from
June 8, 2023 14:09
9a6385e
to
5c6c95b
Compare
andrewhsu
changed the title
tests: cloud failure injector [skip-ci]
tests: cloud failure injector
Jun 9, 2023
andrewhsu
force-pushed
the
cloud-failure-injector
branch
2 times, most recently
from
June 9, 2023 14:10
a591a36
to
0570f25
Compare
andrewhsu
changed the title
tests: cloud failure injector
tests: cloud failure injector [skip-ci]
Jun 12, 2023
andrewhsu
force-pushed
the
cloud-failure-injector
branch
5 times, most recently
from
June 14, 2023 15:59
6b26de5
to
b180615
Compare
andrewhsu
changed the title
tests: cloud failure injector [skip-ci]
tests: cloud failure injector
Jun 14, 2023
andrewhsu
force-pushed
the
cloud-failure-injector
branch
from
June 14, 2023 16:00
b180615
to
d57cb1a
Compare
andrewhsu
force-pushed
the
cloud-failure-injector
branch
from
June 15, 2023 14:42
d57cb1a
to
6e968e6
Compare
andrewhsu
commented
Jun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joejulian i could use your review on just this file everything-allowed-exec-pod.yml
andrewhsu
force-pushed
the
cloud-failure-injector
branch
from
June 15, 2023 14:59
6e968e6
to
8da1169
Compare
In preparation for a subclass specific to Redpanda Cloud. No functionality change for existing FailureInjector class.
andrewhsu
force-pushed
the
cloud-failure-injector
branch
from
June 15, 2023 18:03
8da1169
to
a53d741
Compare
looks like existing known failure: this PR is ready for review |
joejulian
approved these changes
Jun 16, 2023
ivotron
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/redpanda-data/devprod/issues/680
No changes to existing test behaviour that does not use redpanda cloud.
This PR adds a factory method
make_failure_injector()
to instantiate object from either the existing behaviourFailureInjector
class or the newly-added classFailureInjectorCloud
based on config settings inducktape_globals.json
(similar to factory pattern in PR #10521)A simple test class
FailureInjectorSelfTest
is created intests/rptest/tests/services_self_test.py
to test the_isolate()
method on cloud if cloud is enabled in the globals config file. I verified test passes with a cluster that was created before ducktape was run:results:
Backports Required
Release Notes