Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few v::bytes clean-ups #11381

Merged
merged 5 commits into from
Jun 14, 2023
Merged

A few v::bytes clean-ups #11381

merged 5 commits into from
Jun 14, 2023

Conversation

dotnwat
Copy link
Member

@dotnwat dotnwat commented Jun 13, 2023

  • Mostly interface cleanup (rename, remove dead code, simplify constructors)

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.1.x
  • v22.3.x
  • v22.2.x

Release Notes

  • none

dotnwat added 4 commits June 12, 2023 22:59
@dotnwat
bytes: simplify iobuf fragment constructors
8174ca3 
Removes the tagged initialization in favor of simple constructors with
intuitive behavior.

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bytes: remove gcc warning ignores
008a69f 
Added back with GCC 11. Now we are on GCC 13 and don't use GCC. Let's
add back in the future if needed.

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
bytes: remove unused code
d960852 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
iobuf: allocate fragments with std::make_unique
353ecec 
Simplify the interface and squash clang-tidy complaints.

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat dotnwat requested review from BenPope, mmaslankaprv and graphcareful and removed request for BenPope June 13, 2023 06:05
@dotnwat dotnwat changed the title A few libbytes clean-ups A few v::bytes clean-ups Jun 13, 2023
@dotnwat
Copy link
Member Author

dotnwat commented Jun 13, 2023

Failures

BenPope
BenPope reviewed Jun 13, 2023
View reviewed changes
src/v/bytes/iobuf.h Outdated Show resolved Hide resolved
BenPope
BenPope reviewed Jun 13, 2023
View reviewed changes
Copy link
Member

@BenPope BenPope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dotnwat
iobuf: rename append_take_ownership to append
a42d435 
Now that it accepts a unique_ptr the idea that it takes ownership is
expressed through its parameter type.

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
Copy link
Member Author

dotnwat commented Jun 14, 2023

Failures:

@dotnwat dotnwat merged commit 0d34d82 into redpanda-data:dev Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenPope BenPope BenPope approved these changes

@mmaslankaprv mmaslankaprv Awaiting requested review from mmaslankaprv

@graphcareful graphcareful Awaiting requested review from graphcareful

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dotnwat @BenPope