Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.1.x] Avoid duplicate group names in the test in snc trhoughput config test #11393

Merged
merged 1 commit into from
Jun 14, 2023
Merged

[v23.1.x] Avoid duplicate group names in the test in snc trhoughput config test #11393

merged 1 commit into from
Jun 14, 2023

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #11339
Fixes #11392,

@dlex @vbotbuildovich
tests: avoid duplicate group names in the test
e57d5b0 
The test could create two kafka_throughput_control groups with empty
names, or other identical names. Group names are required to be unique
when present. This change guarantees unique group names provided by
the test.

(cherry picked from commit cf8e16b)
@vbotbuildovich vbotbuildovich added this to the v23.1.x-next milestone Jun 13, 2023
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Jun 13, 2023
@dlex
Copy link
Contributor

dlex commented Jun 13, 2023

CI failure in https://buildkite.com/redpanda/redpanda/builds/31202#0188b5ce-1f8b-42ac-9ce0-b2e5467d2704

@dlex dlex marked this pull request as ready for review June 13, 2023 20:32
dlex
dlex approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@dlex dlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified as identical to #11339

@dlex dlex merged commit adcbe73 into redpanda-data:v23.1.x Jun 14, 2023
@vshtokman vshtokman modified the milestones: v23.1.x-next, v23.1.13 Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlex dlex dlex approved these changes

@dotnwat dotnwat Awaiting requested review from dotnwat

@graphcareful graphcareful Awaiting requested review from graphcareful

Assignees
No one assigned
Labels
kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v23.1.13
Development

Successfully merging this pull request may close these issues.
3 participants
@vbotbuildovich @dlex @vshtokman