Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk: change required kernel version in rpk redpanda check + change log levels to rpk checker message. #11502

Merged
merged 3 commits into from
Jun 16, 2023
Merged

rpk: change required kernel version in rpk redpanda check + change log levels to rpk checker message. #11502

merged 3 commits into from
Jun 16, 2023

Conversation

r-vasquez
Copy link
Contributor

@r-vasquez r-vasquez commented Jun 16, 2023 •
edited
Loading

This PR:

  • Changes the required kernel version from 4.9 to 3.9 in the rpk checkers. (rpk redpanda check / rpk redpanda start)
  • Fixes a small error handling bug while reading redpanda.yaml
  • Adds the severity to the failure message of the rpk checkers + move the log level to warning instead of INFO

Before:

System check 'RFS Table entries' failed. Required: >= 32768, Current 0, Error: <nil>
System check 'Swappiness' failed. Required: 1, Current 60, Error: <nil>
System check - PASSED

Now:

11:47:14.830  WARN  System check 'RFS Table entries' failed. Required: >= 32768, Current 0, Error: <nil>, Severity: Warning
11:47:14.830  WARN  System check 'Swappiness' failed. Required: 1, Current 60, Error: <nil>, Severity: Warning
System check - PASSED

Fixes #11439

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.1.x
  • v22.3.x
  • v22.2.x

Release Notes

Bug Fixes

  • rpk: change required kernel version from 4.9 to 3.9 in rpk redpanda check and rpk redpanda start.

r-vasquez added 3 commits June 16, 2023 11:23
@r-vasquez
rpk: fix kernel version checker.
fbe5c97 
We were checking if the version was >= 4.19 while
redpanda supports >= 3.19.
@r-vasquez
rpk: fix error handling bug while reading redpanda.yaml
95f6d81 
If the error was not of the type
afero.ErrFileNotFound, then rpk would have
processed the file (empty) as if it had been
correctly read.
@r-vasquez
rpk: add severity to checker logs, move to warn level
bf2076b
@r-vasquez r-vasquez changed the title Check fix rpk: change required kernel version in rpk redpanda check + change log levels to rpk checker message. Jun 16, 2023
@r-vasquez
Copy link
Contributor Author

r-vasquez commented Jun 16, 2023 •
edited
Loading

Unrelated CI Failures:

Build Issue
https://buildkite.com/redpanda/redpanda/builds/31493#0188c54e-3b8a-43d6-8321-e2f1d9987421/184-6423 #11066
https://buildkite.com/redpanda/redpanda/builds/31493#0188c55a-b849-47b5-83a6-f6e6c7603e47/244-5756 #10497
https://buildkite.com/redpanda/redpanda/builds/31493#0188c55a-b84b-4a16-b662-e23dd148f362/106-5688 #11062
https://buildkite.com/redpanda/redpanda/builds/31493#0188c55a-b84b-4a16-b662-e23dd148f362/106-5716 #11276

@twmb twmb merged commit 9061994 into redpanda-data:dev Jun 16, 2023
@twmb twmb deleted the check-fix branch June 16, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twmb twmb twmb approved these changes

@gene-redpanda gene-redpanda Awaiting requested review from gene-redpanda gene-redpanda is a code owner

Assignees
No one assigned
Labels
area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning level checkers logs in rpk as marked as required and not explicit about severity.
2 participants
@r-vasquez @twmb