Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v22.2.x] k/protocol: Checking for tag value to be 0 #11644

Merged
merged 3 commits into from
Jun 27, 2023
Merged

[v22.2.x] k/protocol: Checking for tag value to be 0 #11644

merged 3 commits into from
Jun 27, 2023

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #11443
Fixes #11642,

@michael-redpanda @vbotbuildovich
k/protocol: Checking for tag value to be 0
1e21516 
Tag fields that are primitives should not be encoded if their value is
equal to 0.

Fixes: redpanda-data#11358

Signed-off-by: Michael Boquard <michael@redpanda.com>
(cherry picked from commit 5991376)
@michael-redpanda @vbotbuildovich
k/protocol: Don't terminate if provided unknown error code
9d6e2c4 
We shouldn't crash if we parse an unknown error code.

Signed-off-by: Michael Boquard <michael@redpanda.com>
(cherry picked from commit 90de7ca)
@vbotbuildovich vbotbuildovich added this to the v22.2.x-next milestone Jun 23, 2023
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Jun 23, 2023
@michael-redpanda michael-redpanda marked this pull request as ready for review June 23, 2023 17:43
@NyaliaLui
Copy link
Contributor

@michael-redpanda looks like there is some compile issues here with src/v/kafka/protocol/errors.cc

@michael-redpanda
k/protocol/test: Added unit test for optional tag values
6d6c46d 
Signed-off-by: Michael Boquard <michael@redpanda.com>
(cherry picked from commit e77a935)
@michael-redpanda michael-redpanda force-pushed the backport-pr-11443-v22.2.x-64 branch from f785e5f to 6d6c46d Compare June 26, 2023 14:43
@michael-redpanda
Copy link
Contributor

Force push 6d6c46d:

  • added missing typename that was required in clang14 but wasn't in clang16
  • replaced kafka::protocol::decoder with older kafka::request_reader (same with encode/request_writer)
  • removed extra field in createable_topics_response structure creation in test
  • ran clang14 format

@michael-redpanda michael-redpanda self-assigned this Jun 26, 2023
@michael-redpanda michael-redpanda merged commit 6fd9234 into redpanda-data:v22.2.x Jun 27, 2023
@BenPope BenPope modified the milestones: v22.2.x-next, v22.2.14 Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NyaliaLui NyaliaLui NyaliaLui approved these changes

@BenPope BenPope Awaiting requested review from BenPope

@twmb twmb Awaiting requested review from twmb

Assignees

@michael-redpanda michael-redpanda

Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v22.2.14
Development

Successfully merging this pull request may close these issues.
4 participants
@vbotbuildovich @NyaliaLui @michael-redpanda @BenPope