Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.1.x] k/protocol: Checking for tag value to be 0 #11645

Merged
merged 3 commits into from
Jun 27, 2023
Merged

[v23.1.x] k/protocol: Checking for tag value to be 0 #11645

merged 3 commits into from
Jun 27, 2023

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #11443
Fixes #11643,

@michael-redpanda @vbotbuildovich
k/protocol: Checking for tag value to be 0
d2bb25b 
Tag fields that are primitives should not be encoded if their value is
equal to 0.

Fixes: redpanda-data#11358

Signed-off-by: Michael Boquard <michael@redpanda.com>
(cherry picked from commit 5991376)
@michael-redpanda @vbotbuildovich
k/protocol: Don't terminate if provided unknown error code
942d23b 
We shouldn't crash if we parse an unknown error code.

Signed-off-by: Michael Boquard <michael@redpanda.com>
(cherry picked from commit 90de7ca)
@vbotbuildovich vbotbuildovich added this to the v23.1.x-next milestone Jun 23, 2023
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Jun 23, 2023
@michael-redpanda michael-redpanda marked this pull request as ready for review June 23, 2023 17:43
@BenPope
Copy link
Member

BenPope commented Jun 26, 2023

@michael-redpanda This might happen quite a lot, I wonder if you should run the linter as part of backporting.

@michael-redpanda
Copy link
Contributor

@michael-redpanda This might happen quite a lot, I wonder if you should run the linter as part of backporting.

The automated cherry-picking by the bot is probably always going to fail at this point (until we stop supporting builds that depend on clang14, which is going to be a while).

@michael-redpanda
k/protocol/test: Added unit test for optional tag values
9ba3cee 
Signed-off-by: Michael Boquard <michael@redpanda.com>
(cherry picked from commit e77a935)
@michael-redpanda michael-redpanda force-pushed the backport-pr-11443-v23.1.x-108 branch from 77e57d1 to 9ba3cee Compare June 26, 2023 14:21
@michael-redpanda
Copy link
Contributor

Force push 9ba3cee:

  • added missing typename that was required in clang14 but wasn't in clang16
  • replaced kafka::protocol::decoder with older kafka::request_reader (same with encode/request_writer)
  • ran clang14 format

@michael-redpanda
Copy link
Contributor

Build failure waiting on #11690

@michael-redpanda michael-redpanda self-assigned this Jun 26, 2023
@NyaliaLui
Copy link
Contributor

I couldn't tell if you restarted the build, so I clicked retry button @michael-redpanda

@michael-redpanda
Copy link
Contributor

Rerunning CI now that #11712 has merged and fixed the unit test bug

@michael-redpanda
Copy link
Contributor

CI failure:

@NyaliaLui NyaliaLui merged commit 36884d1 into redpanda-data:v23.1.x Jun 27, 2023
@BenPope BenPope modified the milestones: v23.1.x-next, v23.1.14 Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NyaliaLui NyaliaLui NyaliaLui approved these changes

@BenPope BenPope Awaiting requested review from BenPope

@twmb twmb Awaiting requested review from twmb

Assignees

@michael-redpanda michael-redpanda

Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v23.1.14
Development

Successfully merging this pull request may close these issues.
4 participants
@vbotbuildovich @BenPope @michael-redpanda @NyaliaLui