[v22.3.x] k/protocol: Checking for tag value to be 0 #11647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tag fields that are primitives should not be encoded if their value is equal to 0. Fixes: redpanda-data#11358 Signed-off-by: Michael Boquard <michael@redpanda.com> (cherry picked from commit 5991376)
We shouldn't crash if we parse an unknown error code. Signed-off-by: Michael Boquard <michael@redpanda.com> (cherry picked from commit 90de7ca)
NyaliaLui
previously requested changes
Jun 26, 2023
There was a problem hiding this comment.
@michael-redpanda looks like there's some compile errors here in src/v/kafka/protocol/errors.cc
Signed-off-by: Michael Boquard <michael@redpanda.com> (cherry picked from commit e77a935)
michael-redpanda
force-pushed
the
backport-pr-11443-v22.3.x-296
branch
from
9e034a2 to
bfcd287
Compare
|
Force push
|
NyaliaLui
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #11443
Fixes #11646,