[v23.1.x] topic_recovery_service: coro -> continuation for collect_manifest_paths #11732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andijcr
changed the title
7 tasks
arm64 + clang-14 causes a miscompilation of this coroutine (evidence: prefix should be in the form "[0-f]0000000" but it can appear in tests as 0000000. this commit translate the coroutine code into a chain of futures. return type is also simplified, since the error result was never set partial backport of e37eabd and backport of 3adac73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arm64 + clang-14 causes a miscompilation of this coroutine (evidence: prefix should be in the form "[0-f]0000000" but it can appear in tests as 0000000.
This commit translates the coroutine code into a chain of futures.
The return type is also simplified since the error result was never set
Fixes #10842
partial backport of e37eabd and backport of 3adac73
Backport of PR #10853
Backports Required
Release Notes