Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed taking snapshot in rm_stm #12155

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Fixed taking snapshot in rm_stm #12155

merged 2 commits into from
Jul 20, 2023

Conversation

mmaslankaprv
Copy link
Member

@mmaslankaprv mmaslankaprv commented Jul 17, 2023 •
edited
Loading

This change fixes an issue where a snapshot might
have been created with offset lower from the offset of a snapshot that
was already applied.

Fixes: #11659

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.2.x
  • v23.1.x
  • v22.3.x
  • v22.2.x

Release Notes

Improvements

  • reduces amount of data read while bootstrapping rm_stm

rystsov
rystsov previously requested changes Jul 17, 2023
View reviewed changes
src/v/cluster/rm_stm.cc Show resolved Hide resolved
@mmaslankaprv mmaslankaprv requested a review from rystsov July 17, 2023 16:59
@BenPope
Copy link
Member

BenPope commented Jul 17, 2023

Any other backports required here?

@mmaslankaprv
Copy link
Member Author

/ci-repeat 4
skip-units
debug
dt-repeat=100
tests/rptest/tests/partition_movement_test.py::SIPartitionMovementTest.test_cross_shard

1 similar comment
@mmaslankaprv
Copy link
Member Author

/ci-repeat 4
skip-units
debug
dt-repeat=100
tests/rptest/tests/partition_movement_test.py::SIPartitionMovementTest.test_cross_shard

@mmaslankaprv
Copy link
Member Author

/ci-repeat 4
skip-units
release
dt-repeat=100
tests/rptest/tests/partition_movement_test.py::SIPartitionMovementTest.test_cross_shard

1 similar comment
@mmaslankaprv
Copy link
Member Author

/ci-repeat 4
skip-units
release
dt-repeat=100
tests/rptest/tests/partition_movement_test.py::SIPartitionMovementTest.test_cross_shard

@rystsov rystsov dismissed their stale review July 18, 2023 22:57

the issue was fixed

@mmaslankaprv
Copy link
Member Author

/ci-repeat 1

@mmaslankaprv mmaslankaprv marked this pull request as ready for review July 19, 2023 06:21
@mmaslankaprv mmaslankaprv requested review from bharathv and ztlpn July 19, 2023 06:21
ztlpn
ztlpn approved these changes Jul 19, 2023
View reviewed changes
src/v/cluster/persisted_stm.cc Show resolved Hide resolved
@mmaslankaprv
c/persisted_stm: update snapshot offset in persisted stm
127521f 
When snapshot is applied on startup by the persisted stm
it should not be the stm implementer responsibility to store
`_last__snapshot_offset`.

Signed-off-by: Michal Maslanka <michal@redpanda.com>
@mmaslankaprv
rm_stm: changed logging of rm_stm snapshot offset
d57a532 
Signed-off-by: Michal Maslanka <michal@redpanda.com>
@mmaslankaprv
Copy link
Member Author

/ci-repeat 1

@mmaslankaprv
Copy link
Member Author

ci failure: #12275

@mmaslankaprv mmaslankaprv merged commit 40d0a10 into redpanda-data:dev Jul 20, 2023
@mmaslankaprv mmaslankaprv deleted the fix-11659 branch July 20, 2023 13:03
@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.1.x

@vbotbuildovich
Copy link
Collaborator

Failed to run cherry-pick command. I executed the commands below:

git checkout -b backport-pr-12155-v23.1.x-335 remotes/upstream/v23.1.x
git cherry-pick -x 127521f987219eab442327b7e211e8bf01cda4d0 d57a5323f8fb7fe56bfc89c646570c031331a03c

Workflow run logs.

This was referenced Jul 20, 2023
Closed
Closed
Merged
@mmaslankaprv mmaslankaprv mentioned this pull request Jul 24, 2023
Merged
7 tasks
mmaslankaprv added a commit that referenced this pull request Jul 24, 2023
@mmaslankaprv
Merge pull request #12401 from mmaslankaprv/v23.1.x-next-bp
06659ee 
[v23.1.x] Backport of #11970 #12155 #11457 #11484 #10801 #11448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ztlpn ztlpn ztlpn approved these changes

@rystsov rystsov Awaiting requested review from rystsov

@bharathv bharathv Awaiting requested review from bharathv

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI Failure (assert target_offset <= _insync_offset) in SIPartitionMovementTest.test_cross_shard
5 participants
@mmaslankaprv @BenPope @vbotbuildovich @rystsov @ztlpn