-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip metrics test on no license #12727
Merged
NyaliaLui
merged 2 commits into
redpanda-data:dev
from
NyaliaLui:skip-metrics-test-on-no-license
Aug 11, 2023
Merged
Skip metrics test on no license #12727
NyaliaLui
merged 2 commits into
redpanda-data:dev
from
NyaliaLui:skip-metrics-test-on-no-license
Aug 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NyaliaLui <nyalia@redpanda.com>
Signed-off-by: NyaliaLui <nyalia@redpanda.com>
graphcareful
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dotnwat
approved these changes
Aug 10, 2023
This was referenced Aug 11, 2023
CI Failure is known and unrelated Retrying CI now ... |
/backport v23.2.x |
/backport v23.1.x |
Failed to run cherry-pick command. I executed the commands below:
|
Failed to run cherry-pick command. I executed the commands below:
|
This was referenced Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should account for carriage return in the license and the metrics reporter test should skip if the license env var is unset.
Fixes: #12719
Fixes: #12718
Backports Required
Release Notes