Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip metrics test on no license #12727

Merged

Conversation

NyaliaLui
Copy link
Contributor

@NyaliaLui NyaliaLui commented Aug 10, 2023

We should account for carriage return in the license and the metrics reporter test should skip if the license env var is unset.

Fixes: #12719
Fixes: #12718

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.2.x
  • v23.1.x
  • v22.3.x

Release Notes

  • none

Signed-off-by: NyaliaLui <nyalia@redpanda.com>
Signed-off-by: NyaliaLui <nyalia@redpanda.com>
Copy link
Contributor

@graphcareful graphcareful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NyaliaLui
Copy link
Contributor Author

NyaliaLui commented Aug 11, 2023

CI Failure is known and unrelated
#12659

Retrying CI now ...

@NyaliaLui NyaliaLui merged commit fff8695 into redpanda-data:dev Aug 11, 2023
@NyaliaLui
Copy link
Contributor Author

/backport v23.2.x

@NyaliaLui
Copy link
Contributor Author

/backport v23.1.x

@vbotbuildovich
Copy link
Collaborator

Failed to run cherry-pick command. I executed the commands below:

git checkout -b backport-pr-12727-v23.2.x-340 remotes/upstream/v23.2.x
git cherry-pick -x f984ac35ba0189915f72e2ffc2dedb331456099b 2a176a5b7ca210678a6e2d16566277a1fa76c7aa

Workflow run logs.

@vbotbuildovich
Copy link
Collaborator

Failed to run cherry-pick command. I executed the commands below:

git checkout -b backport-pr-12727-v23.1.x-830 remotes/upstream/v23.1.x
git cherry-pick -x f984ac35ba0189915f72e2ffc2dedb331456099b 2a176a5b7ca210678a6e2d16566277a1fa76c7aa

Workflow run logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment