Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kafka: Tag connection aborts with abort type #12793

Closed
wants to merge 1 commit into from
Closed

kafka: Tag connection aborts with abort type #12793

wants to merge 1 commit into from

Conversation

StephanDollberg
Copy link
Member

This allows us to differentiate the reason for an abort and also avoid
"expected" error logs.

Fixes #12722
Fixes #12723

Co-Authored-By: Ben Pope ben@redpanda.com

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.2.x
  • v23.1.x
  • v22.3.x

Release Notes

  • none

@StephanDollberg @BenPope
kafka: Tag connection aborts with abort type
f32d9ee 
This allows us to differentiate the reason for an abort and also avoid
"expected" error logs.

Fixes redpanda-data#12722
Fixes redpanda-data#12723

Co-Authored-By: Ben Pope <ben@redpanda.com>
@StephanDollberg
Copy link
Member Author

Failure is:

@StephanDollberg
Copy link
Member Author

/cdt
rp_version=build
tests/rptest/many_partitions_test.py::ManyPartitionsTest.test_many_partitions

1 similar comment
@StephanDollberg
Copy link
Member Author

/cdt
rp_version=build
tests/rptest/many_partitions_test.py::ManyPartitionsTest.test_many_partitions

BenPope
BenPope approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@BenPope BenPope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks.

This was referenced Aug 16, 2023
Closed
Closed
@StephanDollberg
Copy link
Member Author

/cdt
rp_version=build
tests/rptest/scale_tests/many_partitions_test.py::ManyPartitionsTest.test_many_partitions

@StephanDollberg
Copy link
Member Author

Hmm this doesn't seem enough, still getting:

[WARNING - 2023-08-16 12:09:54,592 - redpanda - raise_on_bad_logs - lineno:1228]: [test_many_partitions] Unexpected log line on ip-172-31-14-221: ERROR 2023-08-16 12:04:39,687 [shard 3] kafka - server.cc:154 - Error[applying protocol] remote address: 172.31.1.37:32828 - seastar::abort_requested_exception (abort requested)

This was referenced Aug 23, 2023
Closed
Merged
@BenPope
Copy link
Member

BenPope commented Aug 23, 2023

Hmm this doesn't seem enough, still getting:

[WARNING - 2023-08-16 12:09:54,592 - redpanda - raise_on_bad_logs - lineno:1228]: [test_many_partitions] Unexpected log line on ip-172-31-14-221: ERROR 2023-08-16 12:04:39,687 [shard 3] kafka - server.cc:154 - Error[applying protocol] remote address: 172.31.1.37:32828 - seastar::abort_requested_exception (abort requested)

I rebased and added a small change here: #12955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenPope BenPope BenPope approved these changes

@dotnwat dotnwat dotnwat approved these changes

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
3 participants
@StephanDollberg @BenPope @dotnwat