-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redpanda-Operator: manage decommission for helm charts #12847
Conversation
09353a7
to
866ef6e
Compare
c898680
to
dbc0b8a
Compare
ae0743c
to
9bc6d5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't finish.
src/go/k8s/controllers/redpanda/redpanda_decommission_controller.go
Outdated
Show resolved
Hide resolved
src/go/k8s/controllers/redpanda/redpanda_decommission_controller.go
Outdated
Show resolved
Hide resolved
src/go/k8s/controllers/redpanda/redpanda_decommission_controller_tests.go
Outdated
Show resolved
Hide resolved
src/go/k8s/controllers/redpanda/redpanda_decommission_controller.go
Outdated
Show resolved
Hide resolved
src/go/k8s/controllers/redpanda/redpanda_decommission_controller.go
Outdated
Show resolved
Hide resolved
src/go/k8s/controllers/redpanda/redpanda_decommission_controller.go
Outdated
Show resolved
Hide resolved
src/go/k8s/controllers/redpanda/redpanda_decommission_controller.go
Outdated
Show resolved
Hide resolved
4ed9875
to
069fdf9
Compare
src/go/k8s/controllers/redpanda/redpanda_node_pvc_controller.go
Outdated
Show resolved
Hide resolved
957ad51
to
b814c63
Compare
21e1af1
to
87d34f7
Compare
990ad92
to
91ee0ef
Compare
f479460
to
bd13e73
Compare
051c5fd
to
2b802ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left couple questions
src/go/k8s/controllers/redpanda/redpanda_node_pvc_controller.go
Outdated
Show resolved
Hide resolved
src/go/k8s/controllers/redpanda/redpanda_node_pvc_controller.go
Outdated
Show resolved
Hide resolved
578aa92
to
5ca4cff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…r for scaling down
d5b3337
to
f44fe76
Compare
Merging, remainder of tests have nothing to do with the changes being committed here. There is no need for the clang tests or to wait for them as they will not be triggered anyway. |
/backport v23.2.x |
Calling decommission in the case of changing Pod annotation might be not possible if Pod was removed along with its annotation where previous Redpanda ID was stored. There is dedicated function to handle Ghost brokers. Reference redpanda-data/redpanda#9750 redpanda-data/redpanda#13298 redpanda-data/redpanda#13132 redpanda-data/helm-charts#253 redpanda-data/redpanda#12847
Calling decommission in the case of changing Pod annotation might be not possible if Pod was removed along with its annotation where previous Redpanda ID was stored. There is dedicated function to handle Ghost brokers. Reference redpanda-data/redpanda#9750 redpanda-data/redpanda#13298 redpanda-data/redpanda#13132 redpanda-data/helm-charts#253 redpanda-data/redpanda#12847
Calling decommission in the case of changing Pod annotation might be not possible if Pod was removed along with its annotation where previous Redpanda ID was stored. There is dedicated function to handle Ghost brokers. Reference redpanda-data/redpanda#9750 redpanda-data/redpanda#13298 redpanda-data/redpanda#13132 redpanda-data/helm-charts#253 redpanda-data/redpanda#12847
Calling decommission in the case of changing Pod annotation might be not possible if Pod was removed along with its annotation where previous Redpanda ID was stored. There is dedicated function to handle Ghost brokers. Reference redpanda-data/redpanda#9750 redpanda-data/redpanda#13298 redpanda-data/redpanda#13132 redpanda-data/helm-charts#253 redpanda-data/redpanda#12847
Calling decommission in the case of changing Pod annotation might be not possible if Pod was removed along with its annotation where previous Redpanda ID was stored. There is dedicated function to handle Ghost brokers. Reference redpanda-data/redpanda#9750 redpanda-data/redpanda#13298 redpanda-data/redpanda#13132 redpanda-data/helm-charts#253 redpanda-data/redpanda#12847
Fixes redpanda-data/helm-charts#253
Backports Required
Release Notes
Features