r/consensus: fixed reusing follower sequence id #12990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphcareful
previously approved these changes
Aug 24, 2023
There was a problem hiding this comment.
I can confirm when testing locally this patch fixes the issue where it was initially observed in PR #12716 when testing the ducktape test in the last commit
|
nice find, looks like we are missing some test coverage for linearizable barrier here? worth adding one? |
7 tasks
and what was the situation? presumably it was a duplicate of the value of the first instance of |
mmaslankaprv
force-pushed
the
fix-lb
branch
2 times, most recently
from
7e1ba92 to
441ddec
Compare
graphcareful
previously approved these changes
Aug 25, 2023
bharathv
previously approved these changes
Aug 28, 2023
|
There was a unit test failure in |
mmaslankaprv
dismissed stale reviews from bharathv and graphcareful
via
b0dc9ba
mmaslankaprv
force-pushed
the
fix-lb
branch
2 times, most recently
from
b0dc9ba to
f3f232c
Compare
graphcareful
suggested changes
Aug 30, 2023
|
test failure seems related. |
All the places where follower sequence id is updated use post incrementation. Using pre incrementation operator in heartbeat manager lead to a situation in which two requests were assigned the same sequence_id. Signed-off-by: Michal Maslanka <michal@redpanda.com>
Linerizable barrier should make the `_committed_offset` to advance to the latest possible value. Added flushing of leader log as a part of linearizable barrier to move the `_committed_offset` forward Signed-off-by: Michal Maslanka <michal@redpanda.com>
Grab `_op_lock` in `consensus::lineraizable_barrier` to wait for follower replies to take effect. This makes linearizable_barrier more strict as before returning result leader waits for the follower replies to be processed. Signed-off-by: Michal Maslanka <michal@redpanda.com>
Signed-off-by: Michal Maslanka <michal@redpanda.com>
bharathv
approved these changes
Aug 31, 2023
graphcareful
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the places where follower sequence id is updated use post incrementation. Using pre incrementation operator in heartbeat manager lead to a situation in which two requests were assigned the same
sequence_id.Backports Required
Release Notes