Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v23.2.x] ducktape: avoid writing empty release cache file #13029

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #13019

We noticed one of the CI runs fetched 0 releases and wrote an empty
cache file. We suspect this was because of a transient github issue.
Subsequent upgrade tests failed because they are not able to find
desired previous release in cache.

Rather than waiting for next round of tests to fail, this commit adds a
simple check that avoids writing an empty file essentially failing fast.
Next test should repopulate the file again by fetching the release
metadata from github.

(cherry picked from commit d5c3181)
@vbotbuildovich vbotbuildovich added this to the v23.2.x-next milestone Aug 26, 2023
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Aug 26, 2023
@BenPope
Copy link
Member

BenPope commented Aug 31, 2023

@BenPope BenPope marked this pull request as ready for review August 31, 2023 11:29
@piyushredpanda piyushredpanda merged commit 68e98c9 into redpanda-data:v23.2.x Sep 18, 2023
@piyushredpanda piyushredpanda modified the milestones: v23.2.x-next, v23.2.9 Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants