rptest: Test spillover and timequeries #13034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazin
force-pushed
the
fix/improve-timequery-test
branch
from
1e71407 to
06e63b1
Compare
Extend timequery test to check cloud-storage with and without spillover enabled. Validate that the segments are actuallys spilled by checking the manifest.
Lazin
force-pushed
the
fix/improve-timequery-test
branch
from
06e63b1 to
aa3e9ef
Compare
|
CI failure - #13035 |
andijcr
reviewed
Aug 28, 2023
Comment on lines
+328
to
+329
| assert manifest["archive_start_offset"] == 0 | ||
| assert manifest["start_offset"] > 0 |
There was a problem hiding this comment.
nit:
assert manifest["archive_start_offset"] == 0 && manifest["start_offset"] > 0, f"spillover was setup but it was not generated: {manifest["archive_start_offset"]=} {manifest["start_offset"]=}"
or something along these lines, just to have some context in the remote case this assert fires
andijcr
approved these changes
Aug 28, 2023
|
/backport v23.2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend timequery test to check cloud-storage with and without spillover enabled. Validate that the segments are actuallys spilled by checking the manifest.
Backports Required
Release Notes