[v23.2.x] cloud_storage: use remote index in cloud timequery #13105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 30, 2023 10:58
A lookup by timestamp is added to the remote index. It has the same semantics as the other lookup methods. If the index does not include the time index (i.e. it was created with serde version 1), the search comes up empty. (cherry picked from commit c1d0314)
This commit updates the timequery read path to skip up to the first index entry with a timestamp smaller than the searched one. The result is that timequeries will hydrate/materialize a maximum of two chunks (two because the chunk boundaries don't always line up with the entries in the index). If the index is not present, or was originally created in v1, the search starts from the first chunk as it did previously. (cherry picked from commit da8533b)
A shard-level metric is added to track the total number of chunks that were hydrated (i.e. downloaded). (cherry picked from commit b78d711)
This commit makes a couple of changes to the timequery tests: 1. Run timequery on more offests (10 for each of the 12 segments) 2. Check that a maximum of two chunks are downloaded by any given timequery 3. Use the admin api to get the precise boundary between the cloud and local log. Previously, it was estimated based on record size. (cherry picked from commit 6d507cd)
This commit refactors the handling of the index search result. If a new result type is introduced, it's author will be reminded to handle it by the assertions. (cherry picked from commit de5aa53)
andijcr
approved these changes
Aug 30, 2023
|
Will merge after #13103 merges as that one is big and would be annoying to rebase. |
|
/ci-repeat |
|
Triggered ci-repeat for a rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #13011
Release Notes
Improvements
and reduce the number of hydrated bytes required to serve the query. On average, a time query will have to download 4 times less data (if using the default segment and chunk size)