Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.2.x] rpk profile create: use StringArray rather than StringSlice #13375

Merged
merged 1 commit into from
Sep 12, 2023
Merged

[v23.2.x] rpk profile create: use StringArray rather than StringSlice #13375

merged 1 commit into from
Sep 12, 2023

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #13361

@twmb @vbotbuildovich
rpk profile create: use StringArray rather than StringSlice
b623c8f 
StringSlice splits all inputs at comma, meaning config.Set cannot work.
Currently, people can only input one key=value. If people use a second
value (key=value1,value2), the input is split at comma and then
config.Set runs against value2 alone (no key) and fails.

(cherry picked from commit 80f41e4)
@vbotbuildovich vbotbuildovich added this to the v23.2.x-next milestone Sep 11, 2023
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Sep 11, 2023
@twmb twmb marked this pull request as ready for review September 11, 2023 15:29
@twmb twmb requested review from twmb and r-vasquez as code owners September 11, 2023 15:29
@r-vasquez
Copy link
Contributor

Unrelated Failures:

Build Issue
https://buildkite.com/redpanda/redpanda/builds/36795#018a8508-ed79-42ef-9694-c70551f6e4be/6-4170 #13301
https://buildkite.com/redpanda/redpanda/builds/36795#018a84fc-533b-4ccf-8dd6-690ec44d1b7f/6-3823 #12894

@r-vasquez r-vasquez merged commit b440b60 into redpanda-data:v23.2.x Sep 12, 2023
10 checks passed
@piyushredpanda piyushredpanda modified the milestones: v23.2.x-next, v23.2.9 Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gene-redpanda gene-redpanda gene-redpanda approved these changes

@twmb twmb twmb approved these changes

@r-vasquez r-vasquez Awaiting requested review from r-vasquez r-vasquez is a code owner

Assignees
No one assigned
Labels
area/rpk kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v23.2.9
Development

Successfully merging this pull request may close these issues.
5 participants
@vbotbuildovich @r-vasquez @twmb @gene-redpanda @piyushredpanda