Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/log_segment_appender_test: add test context for run_concurret_append_flush #13733

Conversation

andijcr
Copy link
Contributor

@andijcr andijcr commented Sep 27, 2023

adds some test context in case of failure of the test test_concurrent_append_flush

The core issue is that the appender inflights list is expected to be empty at that point in the test.

Related to #13035

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.2.x
  • v23.1.x
  • v22.3.x

Release Notes

  • none

@vbotbuildovich
Copy link
Collaborator

@andijcr
Copy link
Contributor Author

andijcr commented Sep 27, 2023

issue is #13736

@rystsov
Copy link
Contributor

rystsov commented Sep 27, 2023

issue is #13736

please comment if it's known or new issue and if it's new then why do you think it isn't related to the PR

@andijcr
Copy link
Contributor Author

andijcr commented Sep 28, 2023

issue is #13736

please comment if it's known or new issue and if it's new then why do you think it isn't related to the PR

It's new, but this pr just adds logging in a unit test, so it's excluded that it could influence ducktape

Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andijcr andijcr merged commit a030134 into redpanda-data:dev Sep 29, 2023
10 checks passed
@andijcr andijcr deleted the issue/13035/unit_test_concurrent_append_flush branch September 29, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants