archival: rely on the batch formation logic in remote #13916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since redpanda-data#13720, `remote::delete_objects` can handle inputs of any size and will split them in batches of the appropriate size for each backend. Simplify the code by removing the unnecessary duplication of the batching logic.
|
ducktape was retried in job https://buildkite.com/redpanda/redpanda/builds/38249#018afadb-cc92-41cb-b310-c4acaba94be8 |
|
ducktape was retried in job https://buildkite.com/redpanda/redpanda/builds/38463#018b05ca-3049-46d3-a353-67ee7720c0bd |
nvartolomei
requested review from
VladLazar and
Lazin
and removed request for
VladLazar
VladLazar
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #13720,
remote::delete_objectscan handle inputs of any size and will split them in batches of the appropriate size for each backend.Simplify the code by removing the unnecessary duplication of the batching logic.
Backports Required
Release Notes