cloud_storage: Fix offset for leader epoch request for read-replica #14403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazin
force-pushed
the
pr/rrr-offset-for-leader-epoch
branch
from
8203a82 to
7a8d871
Compare
andrwng
reviewed
Oct 24, 2023
| _partition->is_remote_fetch_enabled() | ||
| && _partition->cloud_data_available()) { | ||
| is_read_replica | ||
| || (_partition->is_remote_fetch_enabled() && _partition->cloud_data_available())) { |
There was a problem hiding this comment.
I think in the case is_read_replica && !cloud_data_available(), we should explicitly return nullopt. At least it seems like if the cloud partition is empty, we could hit some asserts:
redpanda/src/v/cluster/partition.cc
Line 315 in 39062df
There was a problem hiding this comment.
In test if the request is performed before we sync it returns -1, but I added the fix just in case
RRR partition can return incorrect offset for epoch because it uses information from local Raft group. This commit fixes the issue by always using data from the cloud storage if the topic is a read-replica.
Lazin
force-pushed
the
pr/rrr-offset-for-leader-epoch
branch
from
7a8d871 to
523bb54
Compare
VladLazar
approved these changes
Oct 25, 2023
Comment on lines
+91
to
+94
| wait_until(has_leader, | ||
| timeout_sec=60, | ||
| backoff_sec=10, | ||
| err_msg="Failed to create a read-replica, no leadership") |
There was a problem hiding this comment.
nit: could use Admin.await_stable_leader
|
I was running the test locally with |
|
/backport v23.2.x |
|
/backport v23.1.x |
|
Failed to create a backport PR to v23.1.x branch. I tried: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read-replica uses local Raft group as a source of information for
OffsetForLeaderEpochrequest. This PR fixes this problem and adds a reproducer in form of ducktape test.Fixes #14402
Backports Required
Release Notes
Bug Fixes