Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIs for disabling topics/partitions and listing them #14461

Merged
merged 10 commits into from
Nov 6, 2023
Merged

APIs for disabling topics/partitions and listing them #14461

merged 10 commits into from
Nov 6, 2023

Conversation

ztlpn
Copy link
Contributor

@ztlpn ztlpn commented Oct 26, 2023

Add admin APIs for setting the disabled flag and storing it in the topic table.

Also add APIs for viewing the cluster-wide list of partitions/list of partitions of a single topic with filtering by the disabled flag.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.2.x
  • v23.1.x
  • v22.3.x

Release Notes

Improvements

  • Added admin APIs for viewing the cluster-wide list of partitions/list of partitions of a single topic.

@ztlpn ztlpn force-pushed the recovery-mode-disable-cmd branch from f11f023 to 825b518 Compare October 26, 2023 14:52
@vbotbuildovich
Copy link
Collaborator

ducktape was retried in job https://buildkite.com/redpanda/redpanda/builds/39882#018b6ca7-4f80-45c1-98d4-111b7d568b2c

@vbotbuildovich
Copy link
Collaborator

ducktape was retried in job https://buildkite.com/redpanda/redpanda/builds/39882#018b6cc7-9c99-468d-aeec-8adebf699b05

@ztlpn ztlpn force-pushed the recovery-mode-disable-cmd branch from cc9ede4 to 0fcaaa3 Compare October 26, 2023 23:11
@ztlpn ztlpn marked this pull request as ready for review October 26, 2023 23:56
@ztlpn ztlpn requested review from mmaslankaprv and bharathv and removed request for mmaslankaprv October 26, 2023 23:56
@ztlpn ztlpn self-assigned this Oct 26, 2023
@ztlpn ztlpn mentioned this pull request Oct 27, 2023
Closed
@ztlpn
Copy link
Contributor Author

ztlpn commented Oct 27, 2023

unit test timeout is #14254

mmaslankaprv
mmaslankaprv reviewed Oct 30, 2023
View reviewed changes
src/v/redpanda/admin/api-doc/cluster.json Outdated
{
"method": "GET",
"summary": "Get cluster-level metadata for a single partition",
"nickname": "get_cluster_partitions_topic_partition",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this different from /v1/partitions/<ns>/<topic>/<id> ?

@mmaslankaprv
Copy link
Member

The code lgtm, but i am wondering why we need cluster/partitions endpoint, for me it is almost identical to /v1/partitions

@ztlpn ztlpn force-pushed the recovery-mode-disable-cmd branch from 0fcaaa3 to 0451ed9 Compare November 3, 2023 14:24
@ztlpn ztlpn requested a review from mmaslankaprv November 3, 2023 14:25
@vbotbuildovich
Copy link
Collaborator

ducktape was retried in job https://buildkite.com/redpanda/redpanda/builds/40389#018b95d3-aa02-4a91-8298-e7966182ac28

@vbotbuildovich
Copy link
Collaborator

ducktape was retried in job https://buildkite.com/redpanda/redpanda/builds/40389#018b95e3-dab4-41e4-8a91-ff3ea6656c3d

@ztlpn
Copy link
Contributor Author

ztlpn commented Nov 3, 2023

Tests passed, ducktape errors should be fixed by https://github.com/redpanda-data/vtools/pull/2296

mmaslankaprv
mmaslankaprv previously approved these changes Nov 6, 2023
View reviewed changes
ztlpn added 9 commits November 6, 2023 18:09
@ztlpn
features: add disabling_partitions feature
b91ae5b
@ztlpn
cluster: add set_topic_partitions_disabled_cmd controller command
725a551
@ztlpn
cluster: apply set_topic_partitions_disabled_cmd to topic_table
cbd1f90
@ztlpn
c/topics_frontend: add set_topic_partitions_disabled method
979afe6
@ztlpn
admin: add POST /v1/cluster/partitions/{ns}/{topic}[/{id}] handlers
e08490d 
Currently the only functionality is setting topic/partitions disabled
@ztlpn
admin: add disabled flag to existing get_partition results
15f3097
@ztlpn
admin: add GET /v1/cluster/partitions/{ns}/{topic} handler
a7a2170 
Viewing cluster-wide info for partitions of a single topic + disabled
filter.
@ztlpn
admin: add GET /v1/cluster/partitions handler
7c73a28 
Viewing cluster-wide info for all partitions + disabled filter.
@ztlpn
tests/admin: add support for setting/listing disabled partitions
904ea5c
@ztlpn ztlpn force-pushed the recovery-mode-disable-cmd branch from 0451ed9 to 62477b6 Compare November 6, 2023 17:15
@ztlpn ztlpn requested a review from mmaslankaprv November 6, 2023 17:21
@vbotbuildovich
Copy link
Collaborator

new failures detected in https://buildkite.com/redpanda/redpanda/builds/40521#018ba5f3-fcc5-48be-b826-1f9f4375a34c: "rptest.tests.cloud_storage_timing_stress_test.CloudStorageTimingStressTest.test_cloud_storage.cleanup_policy=delete"

@ztlpn
Copy link
Contributor Author

ztlpn commented Nov 6, 2023

scrub failure in CloudStorageTimingStressTest unrelated, probably related to #14349

@ztlpn ztlpn merged commit 41fe7dc into redpanda-data:dev Nov 6, 2023
24 checks passed
@r-vasquez r-vasquez mentioned this pull request Nov 9, 2023
Merged
7 tasks
@ztlpn ztlpn deleted the recovery-mode-disable-cmd branch November 27, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaslankaprv mmaslankaprv mmaslankaprv approved these changes

@bharathv bharathv Awaiting requested review from bharathv

Assignees

@ztlpn ztlpn

Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ztlpn @vbotbuildovich @mmaslankaprv