archival: start reupload range after log start #14816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a delete-records request, when collecting segments to determine the next upload candidate, we could end up trying to build an upload candidate with a start offset lower than the local log. Consider the following sequence: - Segment [0, 200)[200-400) are merge compacted ==> [0, 400). - Delete records ==> start offset is now 1. - Reupload our first compacted segment so we look up offset 1, realign the collection start target to a remote segment 200. - We collect segments starting from 200, getting [0, 400). - Collector gets realigned to 0 since it's the first segment. The collector now thinks it should be uploading [0, 400). - In building the upload candidate, we try to translate the range start and fail because the range start 0 is lower than the translation range start 1. This fixes this sequence to return [200, 400) as the start of the upload candidate.
|
ducktape was retried in job https://buildkite.com/redpanda/redpanda/builds/40649#018bac83-58ab-4a26-9181-442ce4db7576 |
|
The change makes sense to me but I don't quite follow the scenario listed in the PR description:
wouldn't we only get the second segment if we start collecting at 200? |
In this case, our local log only has segment [0, 400) since [0, 200)[200, 400) have been compacted, so only [0, 400) is available to be collected |
|
CI failure: #13787 |
abhijat
approved these changes
Nov 8, 2023
|
/backport v23.2.x |
dotnwat
reviewed
Nov 10, 2023
| @@ -1039,6 +1040,87 @@ SEASTAR_THREAD_TEST_CASE(test_do_not_reupload_self_concatenated) { | |||
| } | |||
| } | |||
|
|
|||
| SEASTAR_THREAD_TEST_CASE(test_do_not_reupload_prefix_truncated) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a delete-records request, when collecting segments to determine the next upload candidate, we could end up trying to build an upload candidate with a start offset lower than the local log. Consider the following sequence:
This fixes this sequence to return [200, 400) as the start of the upload candidate.
Backports Required
Release Notes
Bug Fixes