c/archival_stm: translate sync error to not_leader error code #14978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `persisted_stm::sync()` method fails it is indicating that the current node is not longer a leader. The `sync()` executed before `replicate` call in archival stm `command_batch_builder` prevents replicate from being called. The end result for such an error is deterministic and we can translate the sync error to `not_leader` error code. Fixes: redpanda-data#14898 Signed-off-by: Michal Maslanka <michal@redpanda.com>
It's also possible that it genuinely timed out, but that's probably much less likely. |
VladLazar
approved these changes
Nov 16, 2023
|
/backport v23.2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
persisted_stm::sync()method fails it is indicating that the current node is not longer a leader. Thesync()executed beforereplicatecall in archival stmcommand_batch_builderprevents replicate from being called. The end result for such an error is deterministic and we can translate the sync error tonot_leadererror code.Fixes: #14898
Backports Required
Release Notes