Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RandomNodeOperation test improvements and fixes #15032

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

mmaslankaprv
Copy link
Member

@mmaslankaprv mmaslankaprv commented Nov 20, 2023

Fixed errors leading to spurious error log lines being reported in RandomNodeOperations test

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.2.x
  • v23.1.x
  • v22.3.x

Release Notes

  • none

Signed-off-by: Michal Maslanka <michal@redpanda.com>
Signed-off-by: Michal Maslanka <michal@redpanda.com>
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Nov 20, 2023

Previously validation was failing when `_kafka_start_offset` was
overridden with the same offset. Since re-setting the offset to the same
number doesn't change anything we may relax the validation here.

Signed-off-by: Michal Maslanka <michal@redpanda.com>
@mmaslankaprv mmaslankaprv merged commit 3df4c07 into redpanda-data:dev Nov 21, 2023
21 checks passed
@mmaslankaprv mmaslankaprv deleted the fix-rno branch November 21, 2023 16:03
@mmaslankaprv
Copy link
Member Author

/backport v23.2.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v23.2.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-15032-v23.2.x-953 remotes/upstream/v23.2.x
git cherry-pick -x 839004042a08f9f405f53b19250e02478f3e5626 456fbc757f409ccf07443e8892c297056329a7a7 b1c1d014a1b6b263a465f5796e9586a9ba9150cf

Workflow run logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants