Fix enabling whole topic no-op check #15071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we incorrectly assumed that fully enabling a partially disabled topic is a no-op. This is a no-op is if the topic was previously fully enabled.
ztlpn
force-pushed
the
fix-whole-topic-enable
branch
from
a9fb5f9 to
37dd96c
Compare
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/41497#018bf250-3ad4-458d-a3af-be085b0382c1 |
ztlpn
changed the title
bharathv
approved these changes
Nov 22, 2023
| @@ -4418,12 +4418,12 @@ struct topic_disabled_partitions_set | |||
| bool is_disabled(model::partition_id id) const { | |||
| return !partitions || partitions->contains(id); | |||
| } | |||
| bool is_topic_disabled() const { return !partitions.has_value(); } | |||
| bool is_empty() const { return partitions && partitions->empty(); } | |||
| bool is_fully_disabled() const { return !partitions.has_value(); } | |||
There was a problem hiding this comment.
a general question, for my understanding, is there a difference between partitions=std::nullopt and partitions.empty() = true? Curious if we really need an optional here.
There was a problem hiding this comment.
The difference is explained in the comment a few lines earlier - partitions=nullopt means all partitions are disabled. It looks a bit awkward but I thought that this is better than having a separate "all disabled" flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we incorrectly assumed that fully enabling a partially disabled topic is a no-op. This is a no-op only if the topic was previously fully enabled.
Backports Required
Release Notes