audit: Disable auditing in recovery mode #15228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-redpanda
force-pushed
the
issues/15226
branch
from
92f8d78 to
6460a4b
Compare
graphcareful
suggested changes
Nov 30, 2023
michael-redpanda
force-pushed
the
issues/15226
branch
from
6460a4b to
6fc8182
Compare
Any modification or access to the audit log topic must be audited, regardless of whether or not the event is enabled. This fix ensures that that continues to happen but takes into account whether or not the auditing was actually enabled/disabled. Signed-off-by: Michael Boquard <michael@redpanda.com>
michael-redpanda
force-pushed
the
issues/15226
branch
from
6fc8182 to
159c3a6
Compare
|
Force push
|
|
Force push
|
Signed-off-by: Michael Boquard <michael@redpanda.com>
Signed-off-by: Michael Boquard <michael@redpanda.com>
michael-redpanda
force-pushed
the
issues/15226
branch
from
159c3a6 to
dea71ed
Compare
|
Force push
|
graphcareful
approved these changes
Nov 30, 2023
|
new failures in https://buildkite.com/redpanda/redpanda/builds/42064#018c21be-5597-4d5f-968f-e8d826b2004d: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15226
Audit logging is not able to function in recovery mode as produce messages are rejected. In this situation, it's possible the cluster may become unusable if audit messages are generated and the queues are unable to drain.
Also fixed a logic error in the ducktape tests.
Backports Required
Release Notes