Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow property aliases in redpanda.yaml #15720

Closed
wants to merge 2 commits into from
Closed

allow property aliases in redpanda.yaml #15720

wants to merge 2 commits into from

Conversation

andijcr
Copy link
Contributor

@andijcr andijcr commented Dec 18, 2023 •
edited
Loading

this is a cherry-pick of the commit 4-5 from #15605 to solve the second point,
which is a solution for #15603

2. aliases in bootstrapping redpanda.yaml causing std::illegal_argument exceptions
 - with commit 4-5 include aliases in the list of names to be ignored when setting node config

Fixes #15603

edit: #15605 and #15725 should fix the overall issue now. keeping this to not lose the ✔️

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

Bug Fixes

  • property aliases are properly ignored when read from the bootstrapping redpanda.yaml

andijcr and others added 2 commits December 18, 2023 09:39
@andijcr
config/config_store property_aliases() property_names_and_aliases()
6292249 
property_aliases() mirrors property_names()
and both get merged in property_names_and_aliases(), to be used instead
of property_names when filtering/scanning over user input
@andijcr
config: use property_names_and_aliases()
0736b78 
this allows to include prop aliases when validating external input
@andijcr andijcr marked this pull request as draft December 18, 2023 16:27
@andijcr andijcr closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotnwat dotnwat Awaiting requested review from dotnwat

@graphcareful graphcareful Awaiting requested review from graphcareful

@nvartolomei nvartolomei Awaiting requested review from nvartolomei

@andrwng andrwng Awaiting requested review from andrwng

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

delete_retention_ms migration is not working when included in redpanda.yaml
1 participant
@andijcr