c/log_eviction_stm: do not request snapshot if already progressed #15945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is perfectly possible that the install snapshot request will reach the follower right before the `log_eviction_stm` asks for the snapshot creation. In this case an `stm_manager` would do the check and throw an exception informing that the snapshot can not be taken. In order to handle the situation gracefully added a check in log eviction stm to skip taking snapshot if start offset already progressed. Fixes: redpanda-data#14220 Signed-off-by: Michal Maslanka <michal@redpanda.com>
ztlpn
approved these changes
Jan 4, 2024
|
known failure: #14139 |
|
/backport v23.3.x |
|
Failed to create a backport PR to v23.3.x branch. I tried: |
| @@ -184,13 +184,24 @@ log_eviction_stm::do_write_raft_snapshot(model::offset truncation_point) { | |||
| max_collectible_offset, | |||
| truncation_point); | |||
| } | |||
| if (truncation_point <= _raft->last_snapshot_index()) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is perfectly possible that the install snapshot request will reach the follower right before the
log_eviction_stmasks for the snapshot creation. In this case anstm_managerwould do the check and throw an exception informing that the snapshot can not be taken. In order to handle the situation gracefully added a check in log eviction stm to skip taking snapshot if start offset already progressed.Fixes: #14220
Backports Required
Release Notes