k/replicated_partition: fixed querying end offset of an empty log #17789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When querying offset translator we are relying on the property of the end offset or high watermark being exclusive. Changed the behavior of log end offset to increment offset in Raft offset space and then translate to achieve correct behavior when log is ended with a batch subjected to offset translation. Fixes: redpanda-data#16612 Signed-off-by: Michał Maślanka <michal@redpanda.com>
ztlpn
approved these changes
Apr 11, 2024
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47654#018ecd5b-eadf-4b3b-82fb-97f9661f360f ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47654#018ecd4b-a60e-4643-a0c6-bdc822ad6049 |
|
/backport v23.3.x |
|
/backport v23.2.x |
|
Failed to create a backport PR to v23.3.x branch. I tried: |
|
Failed to create a backport PR to v23.2.x branch. I tried: |
This was referenced Apr 11, 2024
|
Hey :) Is it possible to backport this fix to 23.1. line or it's completely unsupported at this point? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querying offset translator we are relying on the property of the end offset or high watermark being exclusive. Changed the behavior of log end offset to increment offset in Raft offset space and then translate to achieve correct behavior when log is ended with a batch subjected to offset translation.
Fixes: #16612
Credits for @ztlpn for pointing me in the right direction.
Backports Required
Release Notes
Bug Fixes