Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

offline_log_viewer: support transactional offset commit parsing #17937

Merged
merged 1 commit into from
May 9, 2024
Merged

offline_log_viewer: support transactional offset commit parsing #17937

merged 1 commit into from
May 9, 2024

Conversation

bharathv
Copy link
Contributor

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@bharathv bharathv marked this pull request as ready for review May 3, 2024 16:52
@bharathv bharathv requested a review from mmaslankaprv May 3, 2024 16:52
mmaslankaprv
mmaslankaprv previously approved these changes May 4, 2024
View reviewed changes
@mmaslankaprv
Copy link
Member

nit: it would be great to add it to the ducktape tests

@bharathv bharathv force-pushed the tx_commits_offline branch from 92126b1 to 71cde2c Compare May 6, 2024 05:28
@bharathv
Copy link
Contributor Author

bharathv commented May 6, 2024

nit: it would be great to add it to the ducktape tests

Done.

@bharathv bharathv requested a review from mmaslankaprv May 6, 2024 05:29
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented May 6, 2024 •
edited
Loading

new failures in https://buildkite.com/redpanda/redpanda/builds/48737#018f4cb2-c998-4f63-8a6b-d4361cfed0e7:

"rptest.tests.consumer_group_test.ConsumerGroupTest.test_basic_group_join.static_members=True"

new failures in https://buildkite.com/redpanda/redpanda/builds/48737#018f4cb2-c995-4019-b733-302fe9aea5d4:

"rptest.tests.consumer_group_test.ConsumerGroupTest.test_basic_group_join.static_members=False"

@mmaslankaprv
Copy link
Member

it seems that this ci failure is related.

@bharathv bharathv force-pushed the tx_commits_offline branch from 71cde2c to c60b39e Compare May 8, 2024 19:33
@bharathv
Copy link
Contributor Author

bharathv commented May 8, 2024

it seems that this ci failure is related.

fixed.

@bharathv bharathv merged commit e4c83fe into redpanda-data:dev May 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaslankaprv mmaslankaprv mmaslankaprv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bharathv @mmaslankaprv @vbotbuildovich