Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-2627 fix AZURE_AUTHORITY_HOST parsing in azure_ask_refresh_impl #18035

Merged
merged 2 commits into from
Apr 24, 2024
Merged

CORE-2627 fix AZURE_AUTHORITY_HOST parsing in azure_ask_refresh_impl #18035

merged 2 commits into from
Apr 24, 2024

Conversation

andijcr
Copy link
Contributor

@andijcr andijcr commented Apr 23, 2024

AZURE_AUTHORITY_HOST contains URLs in the form of "https://somehostname.com/"

use ada::parse to convert this string to net::unresolved_address.

Fixes CORE-2627

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

Bug Fixes

  • correctly convert URL strings to net::unresolved_address in azure_aks_refresh_impl

andijcr added 2 commits April 23, 2024 23:13
@andijcr
cloud_roles/azure_aks_refresh_impl: parse AZURE_AUTHORITY_HOST as url
038022e 
use ada::parse to parse the content of AZURE_AUTHORITY_HOST. if it
fails, assume it's an hostname
@andijcr
cloud_roles/role_client_tests: test aks AZURE_AUTHORITY_HOST parsing
dad8d8c 
verify the ability to parse an hostname or a more complete url
@andijcr andijcr requested review from dotnwat and abhijat April 23, 2024 21:20
@andijcr andijcr requested a review from c4milo April 23, 2024 21:20
@andijcr andijcr added this to the v24.1.x-next milestone Apr 23, 2024
c4milo
c4milo approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@c4milo c4milo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Apr 23, 2024 •
edited
Loading

new failures in https://buildkite.com/redpanda/redpanda/builds/48184#018f0d28-689f-4c6b-ad2e-b538b5ff5bbb:

"rptest.tests.rbac_upgrade_test.UpgradeMigrationCreatingDefaultRole.test_rbac_migration"

new failures in https://buildkite.com/redpanda/redpanda/builds/48184#018f0d2f-952a-4ddc-84f6-9d03bbe5255a:

"rptest.tests.rbac_upgrade_test.UpgradeMigrationCreatingDefaultRole.test_rbac_migration"

@vbotbuildovich
Copy link
Collaborator

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/48184#018f0d2f-952a-4ddc-84f6-9d03bbe5255a

@piyushredpanda piyushredpanda merged commit c938369 into redpanda-data:dev Apr 24, 2024
13 of 18 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich vbotbuildovich mentioned this pull request Apr 24, 2024
Merged
@andijcr andijcr deleted the fix/CORE-2627/azure_aks_oidc_implementation_parsing_authorithy_host branch April 24, 2024 05:20
@piyushredpanda piyushredpanda modified the milestones: v24.1.x-next, v24.1.2 May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotnwat dotnwat dotnwat approved these changes

@c4milo c4milo c4milo approved these changes

@abhijat abhijat Awaiting requested review from abhijat

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
v24.1.2
Development

Successfully merging this pull request may close these issues.
5 participants
@andijcr @vbotbuildovich @c4milo @dotnwat @piyushredpanda