Reduce raft deps #18043
Merged
Reduce raft deps #18043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move basic named type aliases from `metadata.h` to `fundamental.h`. There is not clear separation between the two but the metadata file contains less common and more complex types. It should be enough to include the `fundamental.h` for most of the cases. Signed-off-by: Michał Maślanka <michal@redpanda.com>
Previously we included `raft/types.h` in every generated RPC service stub. This isn't now required as we moved the definition of transfer leadership related types to separate file. Signed-off-by: Michał Maślanka <michal@redpanda.com>
Signed-off-by: Michał Maślanka <michal@redpanda.com>
Raft `types.h` file contains a lot of definitions that are raft internal. Now that we have `raft/fundamentals.h` we can remove the dependency on `types.h` file Signed-off-by: Michał Maślanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
reduce-raft-deps
branch
from
a98276b to
79bf7ee
Compare
rockwotj
approved these changes
Apr 24, 2024
|
new failures in https://buildkite.com/redpanda/redpanda/builds/48208#018f0ffd-f7f5-4ad2-b8a2-7f824dff1853: new failures in https://buildkite.com/redpanda/redpanda/builds/48208#018f102a-b8b5-49f0-a224-3679950e5d4e: |
|
/ci-repeat 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raft
types.hfile contains a lot of definitions that are raft internal. Now that we haveraft/fundamentals.hwe can remove the dependency ontypes.hfileBackports Required
Release Notes