Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dt/rbac_upgrade: Upgrade to head version instead of a specific 24.x #18055

Merged

Conversation

oleiman
Copy link
Member

@oleiman oleiman commented Apr 24, 2024

The intent of this test is to show that upgrading from a non-RBAC
supporting version to an RBAC supporting build creates the Users
role.

Previously, we would install v24.1.x explicitly. This broke because
we have tagged v24.2.0-dev (which bumps the head version) but have
NOT yet tagged v24.1.1 (so 24.1 doesn't appear in released_versions).

Simplest solution here is to upgrade directly to head version from
a non-RBAC supporting version, which should have the same effect
functionally but is more general.

Fixes CORE-2629

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@oleiman oleiman self-assigned this Apr 24, 2024
@oleiman
Copy link
Member Author

oleiman commented Apr 24, 2024

/ci-repeat 1
skip-units
tests/rptest/tests/rbac_upgrade_test.py::UpgradeMigrationCreatingDefaultRole.test_rbac_migration

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Apr 24, 2024

new failures in https://buildkite.com/redpanda/redpanda/builds/48222#018f1163-4abe-4945-8737-339f325e9de5:

"rptest.tests.rbac_upgrade_test.UpgradeMigrationCreatingDefaultRole.test_rbac_migration"

new failures in https://buildkite.com/redpanda/redpanda/builds/48222#018f116a-8e67-4325-a009-db75f0d00cce:

"rptest.tests.rbac_upgrade_test.UpgradeMigrationCreatingDefaultRole.test_rbac_migration"

The intent of this test is to show that upgrading from a non-RBAC
supporting version to an RBAC supporting build creates the Users
role.

Previously, we would install v24.1.x explicitly. This broke because
we have tagged v24.2.0-dev (which bumps the head version) but have
NOT yet tagged v24.1.1 (so 24.1 doesn't appear in released_versions).

Simplest solution here is to upgrade directly to head version from
a non-RBAC supporting version, which should have the same effect
functionally but is more general.

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
@oleiman oleiman force-pushed the ci/core-2629/upgrade-user-role branch from 7083554 to dd763ce Compare April 24, 2024 18:57
@oleiman oleiman marked this pull request as ready for review April 24, 2024 19:07
@oleiman oleiman marked this pull request as draft April 24, 2024 19:07
@oleiman oleiman marked this pull request as ready for review April 24, 2024 19:08
@oleiman oleiman changed the title some prints (no local repro) dt/rbac_upgrade: Upgrade to head version instead of a specific 24.x Apr 24, 2024
@oleiman oleiman requested review from pgellert, a team and BenPope and removed request for pgellert and a team April 24, 2024 21:15
Copy link
Member

@BenPope BenPope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need changing back to v24.1.1 once it's released?

@oleiman
Copy link
Member Author

oleiman commented Apr 24, 2024

Does this need changing back to v24.1.1 once it's released?

I don't think so. As long as the initial version is <24 (it's fixed to 23.3.something) the effect should be the same. I think the issue here is that v24.1 is now less than the current head version (24.2-dev).

After we tag 24.1.1 we could pin the test back to 24.1, but I can't think of a reason to do so

@oleiman
Copy link
Member Author

oleiman commented Apr 24, 2024

CI Failure: test_cloud_roles_rpunit, which should be fixed by #18052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants