admin: fixed mapping of service unavailable error code #18094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the service_unavailable error code was mapped to generic unexpected server error. This lead to a situation in which a lot of errors were logged when broker was restarted as it has an RPC server running but without the services registered. Changed the mapping of `rpc::errc::service_unavailable` to HTTP service unavailable error. Fixes: redpanda-data#17739 Signed-off-by: Michał Maślanka <michal@redpanda.com>
rockwotj
approved these changes
Apr 26, 2024
BenPope
approved these changes
Apr 26, 2024
yes |
|
/backport v24.1.x |
|
/backport v23.3.x |
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the service_unavailable error code was mapped to generic unexpected server error. This lead to a situation in which a lot of errors were logged when broker was restarted as it has an RPC server running but without the services registered. Changed the mapping of
rpc::errc::service_unavailableto HTTP service unavailable error.Fixes: #17739
Backports Required
Release Notes
Bug Fixes