Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-2062] rpc: convert rpc module to new-style module #18105

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

dotnwat
Copy link
Member

@dotnwat dotnwat commented Apr 26, 2024

rpc: convert rpc module to new-style module

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@dotnwat
Copy link
Member Author

dotnwat commented Apr 26, 2024

AssertionError: Non-exported include found: {PosixPath('rpc/test/test_types.h'), PosixPath('rpc/test/rpc_integration_fixture.h'), PosixPath('rpc/test/echo_v2_service.h'), PosixPath('rpc/test/echo_service.h'), PosixPath('rpc/test/rpc_gen_types.h'), PosixPath('rpc/test/cycling_service.h')}

ahh, these are auto-generated. need to fix the linter i think

rockwotj
rockwotj previously approved these changes Apr 26, 2024
Copy link
Contributor

@rockwotj rockwotj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy button! That's a clean diff. I wish they were all this easy 😄

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat dotnwat force-pushed the rpc-module-new-style branch from 8aec7fe to 94809ac Compare April 26, 2024 17:46
@dotnwat dotnwat requested review from BenPope and a team as code owners April 26, 2024 17:46
@dotnwat dotnwat requested review from savex and removed request for a team April 26, 2024 17:46
@dotnwat dotnwat requested a review from rockwotj April 26, 2024 17:47
@dotnwat
Copy link
Member Author

dotnwat commented Apr 26, 2024

@dotnwat dotnwat removed request for BenPope and savex April 26, 2024 17:47
@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/48353#018f1bd9-a4db-4853-ad9c-e9b416447aca:

"rptest.tests.partition_move_interruption_test.PartitionMoveInterruption.test_cancelling_partition_move.replication_factor=3.unclean_abort=True.recovery=restart_recovery.compacted=False"

@vbotbuildovich
Copy link
Collaborator

@dotnwat
Copy link
Member Author

dotnwat commented Apr 26, 2024

Looks like duplicate failure here #17847

@dotnwat dotnwat merged commit 6f02ffb into redpanda-data:dev Apr 26, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants