wasm: fix host function arg translation #18225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a guest passes a bad buffer, we could throw in args translation and that would cause a C++ exception to be risen into Rust over an FFI boundary, which is bad (TM) and causes a process abort. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
dotnwat
approved these changes
May 2, 2024
oleiman
reviewed
May 2, 2024
|
/backport v24.1.x |
|
/backport v23.3.x |
This was referenced May 3, 2024
|
Followup ticket to add tests to cover this: https://redpandadata.atlassian.net/browse/CORE-1408 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the try/catch block in async host functions to catch arg translation exceptions (from out of bounds buffers being passed).
Otherwise this gets bubbled up over an ABI boundary which is not good (causes an abort).
Backports Required
Release Notes
Bug Fixes