Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk: stop using args[0] in cloud cluster select #18274

Merged
merged 1 commit into from
May 8, 2024
Merged

rpk: stop using args[0] in cloud cluster select #18274

merged 1 commit into from
May 8, 2024

Conversation

r-vasquez
Copy link
Contributor

There might be cases where the user is using
rpk cloud cluster select in a single-cluster org
and args will be null, causing a panic.

Fixes #18270

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented May 7, 2024 •
edited
Loading

new failures in https://buildkite.com/redpanda/redpanda/builds/48756#018f5042-8bdf-4c12-8fa9-0d06735ea207:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48756#018f5042-8bdc-4da2-b0ae-48be5ece6e55:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.ABS"

new failures in https://buildkite.com/redpanda/redpanda/builds/48756#018f504a-7472-49bf-b198-7c81611a41f1:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48756#018f504a-7470-48c4-b6da-b4d5b7c66262:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.ABS"

new failures in https://buildkite.com/redpanda/redpanda/builds/48787#018f53fc-5856-4f25-afd5-c4c4e6b71929:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.ABS"

new failures in https://buildkite.com/redpanda/redpanda/builds/48787#018f53fc-5859-42b0-bd95-fa33946eff3e:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48787#018f5403-8dd8-4bd7-83a2-b29d03be0e8c:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48787#018f5403-8dd6-4e8a-80b5-298bf413dddc:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.ABS"

new failures in https://buildkite.com/redpanda/redpanda/builds/48787#018f546c-22f0-4880-ba2b-76727e9b7d94:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48787#018f5479-4ec8-4a62-a339-baef0bb29036:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.ABS"

new failures in https://buildkite.com/redpanda/redpanda/builds/48787#018f5479-4ecb-4eec-a5da-7d9497421309:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48787#018f546c-342b-4c25-b270-0ae5c8b090ce:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.ABS"

new failures in https://buildkite.com/redpanda/redpanda/builds/48796#018f5517-3bec-4739-9750-1dc68130af41:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48796#018f5527-eff5-4232-ae94-71734b9ccc82:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.ABS"

new failures in https://buildkite.com/redpanda/redpanda/builds/48796#018f5527-eff8-4422-ab83-feb755826c75:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48796#018f5517-3be8-4479-b89a-353943bc5e07:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.ABS"

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented May 7, 2024 •
edited
Loading

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/48756#018f5042-8bdf-4c12-8fa9-0d06735ea207

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/48756#018f5042-8be2-47de-a7fe-3981da57b60b

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/48787#018f53fc-5859-42b0-bd95-fa33946eff3e

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/48796#018f5517-3be8-4479-b89a-353943bc5e07

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/48837#018f593c-1425-4069-9f31-8228735cc6de

@r-vasquez
rpk: stop using args[0] in cloud cluster select
3a9d171 
There might be cases where the user is using
rpk cloud cluster select in a single-cluster org
and args will be null, causing a panic.

Fixes redpanda-data#18270
@r-vasquez r-vasquez force-pushed the fix-panic-select branch from cd58add to 3a9d171 Compare May 8, 2024 16:19
@r-vasquez r-vasquez merged commit e6417b5 into redpanda-data:dev May 8, 2024
22 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

This was referenced May 8, 2024
Closed
Merged
@r-vasquez r-vasquez deleted the fix-panic-select branch May 23, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twmb twmb twmb approved these changes

@gene-redpanda gene-redpanda Awaiting requested review from gene-redpanda gene-redpanda is a code owner

@Deflaimun Deflaimun Awaiting requested review from Deflaimun Deflaimun is a code owner

Assignees
No one assigned
Labels
area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go runtime panic using rpk cloud cluster select
3 participants
@r-vasquez @vbotbuildovich @twmb