Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk: document --set flag in rpk container start #18289

Merged
merged 1 commit into from
May 9, 2024
Merged

rpk: document --set flag in rpk container start #18289

merged 1 commit into from
May 9, 2024

Conversation

r-vasquez
Copy link
Contributor

This has always worked but it is hidden. We now document it.

This is unnecessary but may be a good alternative for testing config properties on start.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented May 7, 2024 •
edited
Loading

new failures in https://buildkite.com/redpanda/redpanda/builds/48795#018f5527-6b15-4ee7-8696-b9e83a805740:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.ABS"

new failures in https://buildkite.com/redpanda/redpanda/builds/48795#018f5517-55bc-4a8a-ae87-6c2687b584e1:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48795#018f5527-6b17-4a96-b0db-1737890fac34:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48795#018f5517-55b9-4097-b208-0fb9ad95a0ce:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.ABS"

new failures in https://buildkite.com/redpanda/redpanda/builds/48867#018f5ae8-731c-4326-8e10-047d6d35a633:

"rptest.tests.nodes_decommissioning_test.NodesDecommissioningTest.test_decommissioning_and_upgrade"

twmb
twmb previously approved these changes May 8, 2024
View reviewed changes
@r-vasquez r-vasquez force-pushed the document-set-container branch from fab6add to d17ba10 Compare May 8, 2024 16:18
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented May 8, 2024 •
edited
Loading

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/48836#018f5954-3c2f-41c7-b23e-b7a189df04ec

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/48867#018f5ae8-7321-410c-8b48-a070f383c4fe

@r-vasquez
rpk: document --set flag in rpk container start
66a153d 
This has always worked but it is hidden, we now
document it.

This is not needed but may be a good alternative
for testing config properties on start.
@r-vasquez r-vasquez force-pushed the document-set-container branch from d17ba10 to 66a153d Compare May 8, 2024 23:57
@r-vasquez
Copy link
Contributor Author

Unit test failure: https://buildkite.com/redpanda/redpanda/builds/48867#018f5aa5-ca10-4eb2-b434-ba27c5b949cc/6-12696 is #13275

@twmb twmb merged commit b0816de into redpanda-data:dev May 9, 2024
19 of 22 checks passed
@twmb twmb deleted the document-set-container branch May 9, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbatuigas kbatuigas kbatuigas left review comments

@twmb twmb twmb approved these changes

@gene-redpanda gene-redpanda Awaiting requested review from gene-redpanda gene-redpanda is a code owner

@Deflaimun Deflaimun Awaiting requested review from Deflaimun Deflaimun is a code owner

Assignees
No one assigned
Labels
area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r-vasquez @vbotbuildovich @twmb @kbatuigas