mvlog: wrap pager with file abstraction #18457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockwotj
reviewed
May 14, 2024
Adds a barebones abstraction around the io:: paging abstractions that looks more like a file, with the goal in mind to abstract away the details of the underlying io:: subsystem. For now, this file abstraction supports appends, reads, and various file lifecycle operations, which is enough to get started using it in development of the new local log.
dotnwat
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a barebones abstraction around the io:: paging abstractions that
looks more like a file, with the goal in mind to abstract away the
details of the underlying io:: subsystem.
For now, this file abstraction supports appends, reads, and various file
lifecycle operations, which is enough to get started using it in
development of the new local log.
This begins to address #17566 but doesn't address if fully. More work will be needed to flesh out concurrency, flushes, etc.
Backports Required
Release Notes