Made client id parsing vcluster aware #18464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michał Maślanka <michal@redpanda.com>
When using mpx protocol extension actual client id is only a part of the whole client id buffer sent by MPX to Redpanda. Added a method allowing overriding client id. Signed-off-by: Michał Maślanka <michal@redpanda.com>
Comment on lines
80
to
98
| vcluster_connection_id parse_vcluster_connection_id(std::string_view str) { | ||
| vcluster_connection_id cid; | ||
| std::stringstream sstream(str.data()); | ||
| sstream >> std::hex >> cid; | ||
| return cid; | ||
| } |
There was a problem hiding this comment.
I think there should be some validation to ensure that the vcluster_connection_id contains only valid hex characters. The streaming operation won't throw any exception if an invalid character is encountered and will simply stop processing.
oleiman
reviewed
May 14, 2024
There was a problem hiding this comment.
couple questions but generally lgtm. I agree with @michael-redpanda - some DT tests for junk input might be nice.
Previously Redpanda virtualized Kafka connections based on the full
client_id string and the string was used as a client id in all
downstream processing.
Change the parsing logic to add context to the parsed client id.
The client id format expected by Redpanda has the following structure:
```
[vcluster_id][connection_id][actual client id]
```
where:
`vcluster_id` - string encoded XID representing virtual cluster
(20 characters)
`connection_id` - hex encoded 32 bit integer representing virtual
connection id (8 characters)
`client_id` - standard protocol defined client id
If Redpanda fails to parse the client id while working with virtualized
connections the whole connection is closed.
Signed-off-by: Michał Maślanka <michal@redpanda.com>
Signed-off-by: Michał Maślanka <michal@redpanda.com>
Signed-off-by: Michał Maślanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
mpx-client-parsing
branch
from
b28ebec to
953135b
Compare
Replaced `node_hash_map` keeping state of virtualized connections with `chunked_hash_map`. The change will allow us to avoid large allocations when dealing with large virtual connection number. Signed-off-by: Michał Maślanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
mpx-client-parsing
branch
from
cb96979 to
187dcbf
Compare
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/49168#018f7d6c-bd71-4c32-8bfe-1f25bc06addd |
|
/backport v24.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Redpanda virtualized Kafka connections based on the full
client_id string and the string was used as a client id in all
downstream processing.
Change the parsing logic to add context to the parsed client id.
The client id format expected by Redpanda has the following structure:
where:
vcluster_id- string encoded XID representing virtual cluster(20 characters)
connection_id- hex encoded 32 bit integer representing virtualconnection id (8 characters)
client_id- standard protocol defined client idIf Redpanda fails to parse the client id while working with virtualized
connections the whole connection is closed.
Backports Required
Release Notes